lkml.org 
[lkml]   [2018]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] remoteproc: q6v5: Add support to vote for rpmh power domains
    On 29 June 2018 at 12:20, Rajendra Nayak <rnayak@codeaurora.org> wrote:
    > With rpmh ARC resources being modelled as power domains with
    > performance state, add support to proxy vote on these for SDM845.
    > Add support to vote on multiple of them, now that genpd supports
    > associating multiple power domains to a device.
    >
    > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
    > ---
    > This patch is dependent on the rpmh powerdomain driver
    > still under review,
    > https://lkml.org/lkml/2018/6/27/7

    I assume you intend to re-spin this to use the new
    dev_pm_domain_attach_by_name(), once 4.19 rc1 is out, right!?

    Anyway, please keep me in the loop.

    [...]

    > + if (num_pds > 1) {
    > + for (i = 0; i < num_pds; i++) {
    > + devs[i] = genpd_dev_pm_attach_by_id(dev, i);

    This API is supposed to be called only by the driver core. Please use
    dev_pm_domain_attach_by_id|name() instead.

    [...]

    Kind regards
    Uffe

    \
     
     \ /
      Last update: 2018-08-03 12:11    [W:4.076 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site