lkml.org 
[lkml]   [2018]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] Remove uneeded variable "err"
From
Date


On 5.08.2018 18:02, zhong jiang wrote:
>
> zhong jiang (3):
> fs/btrfs/disk-io: Remove unneeded variable "err"
> fs/btrfs/extent-tree: remove redudant variable "err"
> fs/btrfs/tree-log: remove the unneeded variable "err"
>
> fs/btrfs/disk-io.c | 12 ++++--------
> fs/btrfs/extent-tree.c | 6 ++----
> fs/btrfs/tree-log.c | 5 +----
> fs/btrfs/tree-log.h | 2 +-
> 4 files changed, 8 insertions(+), 17 deletions(-)
>


NAK on the whole series on the basis of using a bulk commit message
which doesn't really describe the changes of each individual commit. If
you want those changes to eventually be merged resubmit the series with
individual reasoning for every commit.

\
 
 \ /
  Last update: 2018-08-05 21:14    [W:0.062 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site