Messages in this thread | | | Subject | Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err" | From | Joe Perches <> | Date | Sun, 05 Aug 2018 08:27:49 -0700 |
| |
On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote: > The err is not used after initalization, So remove it and make > the function to be void function. [] > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c [] > @@ -4193,7 +4192,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, > if (atomic_read(&delayed_refs->num_entries) == 0) { > spin_unlock(&delayed_refs->lock); > btrfs_info(fs_info, "delayed_refs has NO entry"); > - return ret;
Think a little more about this please. This is not a sensible removal.
> } > > while ((node = rb_first(&delayed_refs->href_root)) != NULL) {
| |