Messages in this thread | | | Subject | Re: [PATCH 3/4] watchdog: hpwdt: Display module parameters. | From | Guenter Roeck <> | Date | Sat, 4 Aug 2018 18:13:20 -0700 |
| |
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: > Print module parameters when the driver is loaded. > > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com> > --- > drivers/watchdog/hpwdt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index 8a85ddd..f098371 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -326,8 +326,9 @@ static int hpwdt_init_one(struct pci_dev *dev, > } > > dev_info(&dev->dev, "HPE Watchdog Timer Driver: %s" > - ", timer margin: %d seconds (nowayout=%d).\n", > - HPWDT_VERSION, hpwdt_dev.timeout, nowayout); > + ", timeout : %d seconds (nowayout=%d) pretimeout=%s.\n", > + HPWDT_VERSION, hpwdt_dev.timeout, nowayout, > + pretimeout ? "on" : "off"); > When touching that, you might as well address
WARNING: quoted string split across lines
Why did you add a space before ':' ? Personal preference ?
Guenter
> if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR) > ilo5 = true; >
| |