Messages in this thread | | | Subject | Re: [PATCH 2/4] watchdog: hpwdt: Claim NMI from iLO | From | Guenter Roeck <> | Date | Sat, 4 Aug 2018 18:09:05 -0700 |
| |
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: > The hwpdt driver is overloaded for handling both the iLO > watchdog and the explicit "Generate NMI to System" virutal > button. > > Claim the iLO NMI virtual button even if we are not claiming > the iLO watchdog pretimeout. > > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Guess you know what you are doing here.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index 369022d..8a85ddd 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -162,7 +162,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) > if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi) > return NMI_DONE; > > - if (ilo5 && !pretimeout) > + if (ilo5 && !pretimeout && !(mynmi & 0x4)) > return NMI_DONE; > > hpwdt_stop(); >
| |