Messages in this thread Patch in this message | | | From | Igor Stoppa <> | Subject | [PATCH 14/23] wimax: i2400m: remove unnecessary unlikely() | Date | Fri, 31 Aug 2018 01:34:20 +0300 |
| |
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another.
Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com> Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> --- drivers/net/wimax/i2400m/tx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wimax/i2400m/tx.c b/drivers/net/wimax/i2400m/tx.c index f20886ade1cc..59c70d928249 100644 --- a/drivers/net/wimax/i2400m/tx.c +++ b/drivers/net/wimax/i2400m/tx.c @@ -655,8 +655,7 @@ void i2400m_tx_close(struct i2400m *i2400m) padding = aligned_size - tx_msg_moved->size; if (padding > 0) { pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0); - if (unlikely(WARN_ON(pad_buf == NULL - || pad_buf == TAIL_FULL))) { + if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) { /* This should not happen -- append should verify * there is always space left at least to append * tx_block_size */ -- 2.17.1
| |