Messages in this thread Patch in this message | | | From | zhong jiang <> | Subject | [PATCH v2] drivers/thermal/tegra: Fix a double free on the device node | Date | Mon, 27 Aug 2018 21:32:18 +0800 |
| |
The function 'for_each_child_of_node' iterates over the node list by dropping the of_node reference of the previous node.
Calling of_node_put() on the iterator is pointless and leads to an inconsistent refcounting in addition to a double free. Remove it.
Acked-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- v1->v2: According to Daniel's suggestion. I modify the subject and commit log.
drivers/thermal/tegra/soctherm.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index ed28110..3aa55c9 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -980,7 +980,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) tcd = thermal_of_cooling_device_register(np_stcc, (char *)name, ts, &throt_cooling_ops); - of_node_put(np_stcc); if (IS_ERR_OR_NULL(tcd)) { dev_err(dev, "throttle-cfg: %s: failed to register cooling device\n", -- 1.7.12.4
| |