lkml.org 
[lkml]   [2018]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC] mm: don't miss the last page because of round-off error
    On Fri, Aug 17, 2018 at 04:18:34PM -0700, Roman Gushchin wrote:
    > - scan = div64_u64(scan * fraction[file],
    > - denominator);
    > + if (scan > 1)
    > + scan = div64_u64(scan * fraction[file],
    > + denominator);

    Wouldn't we be better off doing a div_round_up? ie:

    scan = div64_u64(scan * fraction[file] + denominator - 1, denominator);

    although i'd rather hide that in a new macro in math64.h than opencode it
    here.

    \
     
     \ /
      Last update: 2018-08-18 03:23    [W:13.221 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site