Messages in this thread | | | Date | Fri, 17 Aug 2018 16:50:08 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 4/5] perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint |
| |
On Fri, Aug 10, 2018 at 12:47:29PM +0200, Jiri Olsa wrote: > Currently we enable the breakpoint back only if the breakpoint > modification was successful. If it fails we can leave the > breakpoint in disabled state with attr->disabled == 0. > > We can safely enable the breakpoint back for both the fail > and success paths by checking the bp->attr.disabled, which > either holds the new 'requested' disabled state or the > original breakpoint state. > > Suggested-by: Oleg Nesterov <oleg@redhat.com> > Link: http://lkml.kernel.org/n/tip-79p9ttocwy2ju2s6qh25dvre@git.kernel.org > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Thanks a lot!
| |