Messages in this thread | | | Date | Tue, 14 Aug 2018 12:32:09 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 4/5] perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint |
| |
On 08/10, Jiri Olsa wrote: > > --- a/kernel/events/hw_breakpoint.c > +++ b/kernel/events/hw_breakpoint.c > @@ -523,13 +523,11 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att > perf_event_disable(bp); > > err = modify_user_hw_breakpoint_check(bp, attr, false); > - if (err) > - return err; > > - if (!attr->disabled) > + if (!bp->attr.disabled) > perf_event_enable(bp); > > - return 0; > + return err; > }
Acked-by: Oleg Nesterov <oleg@redhat.com>
| |