Messages in this thread Patch in this message | | | From | Todd Poynor <> | Subject | [PATCH] drivers/staging/gasket: Use refcount_read() | Date | Fri, 6 Jul 2018 23:43:10 -0700 |
| |
From: Todd Poynor <toddpoynor@google.com>
Use the refcount_read accessor function, avoid reaching into refcount and atomic struct fields.
Signed-off-by: Todd Poynor <toddpoynor@google.com> --- drivers/staging/gasket/gasket_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c index d45098c90b4b..b5cdc180772a 100644 --- a/drivers/staging/gasket/gasket_sysfs.c +++ b/drivers/staging/gasket/gasket_sysfs.c @@ -122,7 +122,7 @@ static void put_mapping(struct gasket_sysfs_mapping *mapping) } mutex_lock(&mapping->mutex); - if (mapping->refcount.refcount.refs.counter == 0) + if (refcount_read(&mapping->refcount.refcount) == 0) gasket_nodev_error("Refcount is already 0!"); if (kref_put(&mapping->refcount, release_entry)) { gasket_nodev_info("Removing Gasket sysfs mapping, device %s", -- 2.18.0.203.gfac676dfb9-goog
| |