lkml.org 
[lkml]   [2018]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Use short unix-style option instead of --longname.
Date
Hi.

> -----Original Message-----
> From: Rob Landley [mailto:rob@landley.net]
> Sent: Thursday, July 05, 2018 4:06 AM
> To: trivial@kernel.org; Yamada, Masahiro/山田 真弘
> <yamada.masahiro@socionext.com>; Kees Cook <keescook@chromium.org>; Ulf
> Magnusson <ulfalizer@gmail.com>
> Subject: [PATCH] Use short unix-style option instead of --longname.
>
> From: Rob Landley <rob@landley.net>
>
> Use short unix-style option instead of --longname.

This is the repeat of the subject.
Instead, could you describe the reason of this patch here please?


> Signed-off-by: Rob Landley <rob@landley.net>
> ---
>
> Avoids warning messages with the latest release of toybox, which never
> bothered
> to implement the --longopts nothing was using.

I am fine with this patch,
but I want the information below the --- line
to be recorded in git.


I think WHY is the most important part in the commit log.

If the commit log only mentions 'Use short unix-style option instead of --longname'
it is not easy to know why this commit is necessary.





> init/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 041f3a0..192d400 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -2,9 +2,9 @@ config DEFCONFIG_LIST
> string
> depends on !UML
> option defconfig_list
> - default "/lib/modules/$(shell,uname --release)/.config"
> + default "/lib/modules/$(shell,uname -r)/.config"
> default "/etc/kernel-config"
> - default "/boot/config-$(shell,uname --release)"
> + default "/boot/config-$(shell,uname -r)"
> default ARCH_DEFCONFIG
> default "arch/$(ARCH)/defconfig"
\
 
 \ /
  Last update: 2018-07-05 04:07    [W:0.034 / U:1.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site