lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] rhashtable: don't hold lock on first table throughout insertion.
On Fri, Jul 27, 2018 at 11:04:37AM +1000, NeilBrown wrote:
> On Wed, Jul 25 2018, Paul E. McKenney wrote:
> >>
> >> Looks good ... except ... naming is hard.
> >>
> >> is_after_call_rcu_init() asserts where in the lifecycle we are,
> >> is_after_call_rcu() tests where in the lifecycle we are.
> >>
> >> The names are similar but the purpose is quite different.
> >> Maybe s/is_after_call_rcu_init/call_rcu_init/ ??
> >
> > How about rcu_head_init() and rcu_head_after_call_rcu()?

Very well, I will pull this change in on my next rebase.

Thanx, Paul

\
 
 \ /
  Last update: 2018-07-27 05:19    [W:0.079 / U:1.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site