Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver | From | Jerome Brunet <> | Date | Thu, 19 Jul 2018 09:55:53 +0200 |
| |
On Wed, 2018-07-18 at 17:39 +0200, Takashi Iwai wrote: > On Wed, 18 Jul 2018 13:50:54 +0200, > Mark Brown wrote: > > > > On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote: > > > > > + return !status ? IRQ_NONE : IRQ_HANDLED; > > > > Please just write normal conditional statements, it makes things a lot > > easier to read (the ! isn't helping either here).
Indeed. I'll correct this in a follow up patch
> > ... and there is the standard IRQ_RETVAL() macro for this purpose.
I was not aware of it. Thanks for the tip Takashi
> > > Takashi
| |