lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver
On Wed, 18 Jul 2018 13:50:54 +0200,
Mark Brown wrote:
>
> On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote:
>
> > + return !status ? IRQ_NONE : IRQ_HANDLED;
>
> Please just write normal conditional statements, it makes things a lot
> easier to read (the ! isn't helping either here).

... and there is the standard IRQ_RETVAL() macro for this purpose.


Takashi

\
 
 \ /
  Last update: 2018-07-18 17:40    [W:0.066 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site