Messages in this thread | | | Subject | Re: [PATCH 2/2] i2c: designware: Add support for a bus clock | From | Andy Shevchenko <> | Date | Wed, 18 Jul 2018 15:52:20 +0300 |
| |
On Wed, 2018-07-18 at 13:06 +0200, Geert Uytterhoeven wrote: > On Wed, Jul 18, 2018 at 11:14 AM Simon Horman <horms@verge.net.au> > wrote:
> > if (IS_ERR(dev->buslck) && PTR_ERR(dev->busclk) != -ENOENT) > > return PTR_ERR(dev->busclk); > > > > ... > > As this is a commonly-used construct, perhaps it would be good to > introduce > clk_get_optional() (cfr. gpiod_get_optional()) and > devm_clk_get_optional(), > which would return NULL instead of -ENOENT? > Then it becomes a simple check for IS_ERR() in the driver.
I'm puzzled why CCF still lack of such API.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |