Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Fix macro argument reuse test | From | Joe Perches <> | Date | Sun, 15 Jul 2018 09:34:33 -0700 |
| |
Multiple line macro definitions where the arguments are separated by line continuations can cause checkpatch to emit invalid syntax regex tests.
This can occur when a single argument is modified in a part of a patch.
For example: (to not add a diff in the commit message)
$ ./scripts/checkpatch.pl --git db023296f0115d2fe01fdabad54678f2b806da23 Unterminated \g... pattern in regex; <very long regex omitted>
And, the test does not work correctly when these arguments are all new as the initial patch line addition "+" is used in the argument name.
Fix this by stripping the line continuations and any "+" from the list of arguments.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b5c875d7132b..fa29aebff5a1 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4950,6 +4950,7 @@ sub process { if (defined $define_args && $define_args ne "") { $define_args = substr($define_args, 1, length($define_args) - 2); $define_args =~ s/\s*//g; + $define_args =~ s/\\\+?//g; @def_args = split(",", $define_args); } | |