Messages in this thread | | | Date | Thu, 12 Jul 2018 23:57:22 -0700 (PDT) | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed |
| |
On Fri, Jul 13, 2018 at 09:48:16AM +0300, Dan Carpenter wrote: > On Fri, Jul 13, 2018 at 12:54:16AM +0300, Tuomas Tynkkynen wrote: > > @@ -424,7 +411,9 @@ int bcm2835_audio_open(struct bcm2835_alsa_stream *alsa_stream) > > int status; > > int ret; > > > > - my_workqueue_init(alsa_stream); > > + alsa_stream->my_wq = alloc_workqueue("my_queue", WQ_HIGHPRI, 1); > > + if (!alsa_stream->my_wq) > > + return -ENOMEM; > > > > ret = bcm2835_audio_open_connection(alsa_stream); > > if (ret) { > > This patch is good but if bcm2835_audio_open_connection() fails then > we need to release alsa_stream->my_wq.
Never mind, you handle it in the next patch. The bug *was* there in the original code as well, so that's a legit way to split the patches.
regards, dan carpenter
| |