Messages in this thread | | | Date | Fri, 13 Jul 2018 09:48:16 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed |
| |
On Fri, Jul 13, 2018 at 12:54:16AM +0300, Tuomas Tynkkynen wrote: > @@ -424,7 +411,9 @@ int bcm2835_audio_open(struct bcm2835_alsa_stream *alsa_stream) > int status; > int ret; > > - my_workqueue_init(alsa_stream); > + alsa_stream->my_wq = alloc_workqueue("my_queue", WQ_HIGHPRI, 1); > + if (!alsa_stream->my_wq) > + return -ENOMEM; > > ret = bcm2835_audio_open_connection(alsa_stream); > if (ret) {
This patch is good but if bcm2835_audio_open_connection() fails then we need to release alsa_stream->my_wq.
regards, dan carpenter
| |