lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/19] sched/numa: Evaluate move once per node
* Rik van Riel <riel@surriel.com> [2018-06-04 10:51:27]:

> On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
>
>
> Just bike shedding, but it may be easier to read
> if the "we found our destination" check were written
> more explicitly:
>
>
> if (!cur) {
> if (move && imp > env->best_imp)
> gote assign;
> else
> goto unlock;
> }
>

will incorporate this.


> Also, the "move" variable seems to indicate that
> the NUMA code may move the task, but not a decision
> that moving the task is better than a swap.
>
> Would it make sense to call it "maymove"?

Okay, will incorporate this too.

>
> I like how this patch simplifies the code a little.
>

Thanks.

\
 
 \ /
  Last update: 2018-06-04 17:45    [W:1.134 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site