Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 4 Jun 2018 13:44:38 +0200 | Subject | Re: [PATCH 01/11] macintosh/via-pmu: Fix section mismatch warning |
| |
Hi Finn,
On Sat, Jun 2, 2018 at 5:27 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > The pmu_init() function has the __init qualifier, but the ops struct > that holds a pointer to it does not. This causes a build warning. > The driver works fine because the pointer is only dereferenced early. > > The function is so small that there's negligible benefit from using > the __init qualifier. Remove it to fix the warning, consistent with > the other ADB drivers.
Some other ADB subdriver .init() and .probe() functions aren't that small. But with the current scheme using adb_drivers_list[], they cannot be __init. Probably the long term fix is to change the ADB subsystem from the centralized approach of letting adb_init() call all subdrivers, to making the subdrivers platform drivers registering with the ADB core.
> Tested-by: Stan Johnson <userm57@yahoo.com> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Anyway: Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |