Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 4 Jun 2018 13:48:55 +0200 | Subject | Re: [PATCH 03/11] macintosh/via-pmu: Don't clear shift register interrupt flag twice |
| |
On Sat, Jun 2, 2018 at 5:27 AM, Finn Thain <fthain@telegraphics.com.au> wrote: > Clearing the interrupt flag twice in succession creates a theoretical > race condition. Fix this.
I would add that the caller of pmu_sr_intr() has already cleared the flag, so the casual reviewer doesn't have to hunt for it.
> Tested-by: Stan Johnson <userm57@yahoo.com> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |