lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] cpuidle/powernv : Add Description for cpuidle state
From
Date
On Mon, 2018-06-04 at 13:47 +0530, Abhishek Goel wrote:
> + if (of_property_read_string_array(power_mgt,
> + "ibm,cpu-idle-state-descs", descs, dt_idle_states) < 0) {
> + of_property_read_string_array(power_mgt,
> + "ibm,cpu-idle-state-names", descs, dt_idle_states);
> + pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-descs in DT\n"
> + "Name will be used for description\n");
> + }
>
> /*

Is this a new property ? I'm not fan of adding yet another of those
silly arrays.

I would say this is the right time now to switch over to a node per
state instead, as we discussed with Vaidy.

Additionally, while doing that, we can provide the versioning mechanism
I proposed so we can deal with state specific issues and erratas.

Cheers,
Ben.

\
 
 \ /
  Last update: 2018-06-04 11:05    [W:0.048 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site