lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: checkpatch false positive (IMO): typo detected in truncated commit message
From
Date
On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote:
> Hello!
>
> I got the following message from checkpatch:
>
> =======
> $ scripts/checkpatch.pl
> 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch
> WARNING: 'calle' may be misspelled - perhaps 'called'?
> #15:
> Fixes: 266d07cb1c9a ("netfilter: nf_log: fix sleeping function calle[...]")
>
> total: 0 errors, 1 warnings, 0 checks, 20 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch has
> style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> =======
>
> I believe that it is appropriate here to truncate the commit message
> of the fixed commit.

It's not.

\
 
 \ /
  Last update: 2018-06-25 17:24    [W:0.042 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site