lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] staging: pi433: replace simple switch statements
From
Date
Hi Dan,

I'd like to mention once more, that the idea of the abstraction was to
support multiple modules of Hope-RF.
If the decision of the "team" of developer of this driver is, that it
should be reduced to a Pi433 or RFM69CW driver only, I fully agree,
that the abstraction layer isn't necessary (tough improving readability).

But if the "team" wants to extend the driver - here I explicitly want to
Name Marcin Ciupak and Hogo Lefeuvre, both were discussing this with me -
I highly recommend to keep the abstraction layer.

And once again, I have to announce, that - if noone appears, who wants to
help me with selling Pi433 - I can't effort to let Pi433 on the market
longer then end of this year. From this Point of view on long term it
might be senseless to prepare a Pi433-only driver.

Cheers,
Marcus

Dan Carpenter schrieb am 25.06.2018 14:35:
> I'd still prefer if we just removed this abstraction entirely and used
> OPMODE_MODE_TRANSMIT everywhere instead of bringing "transmit" into it.
>
> I know that every author thinks their abstraction will definitely be
> useful in the future, but generally kernel style is to remove
> abstractions.
>
> But I guess this code is an improvement over the original so the patch
> is fine.
>
> regards,
> dan carpenter
>
>

\
 
 \ /
  Last update: 2018-06-25 15:28    [W:0.041 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site