Messages in this thread | | | Date | Mon, 25 Jun 2018 15:35:54 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v3] staging: pi433: replace simple switch statements |
| |
I'd still prefer if we just removed this abstraction entirely and used OPMODE_MODE_TRANSMIT everywhere instead of bringing "transmit" into it.
I know that every author thinks their abstraction will definitely be useful in the future, but generally kernel style is to remove abstractions.
But I guess this code is an improvement over the original so the patch is fine.
regards, dan carpenter
| |