lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: pi433: replace simple switch statements
I'd still prefer if we just removed this abstraction entirely and used
OPMODE_MODE_TRANSMIT everywhere instead of bringing "transmit" into it.

I know that every author thinks their abstraction will definitely be
useful in the future, but generally kernel style is to remove
abstractions.

But I guess this code is an improvement over the original so the patch
is fine.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-06-25 14:37    [W:0.086 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site