Messages in this thread | | | Date | Thu, 21 Jun 2018 17:17:04 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops() |
| |
On (06/21/18 09:59), Dmitry Vyukov wrote: > > > >> + printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n", > >> + (address < PAGE_SIZE ? "NULL pointer dereference" : > >> + "paging request"), (void *) address); > > > > Perhaps pr_alert() ? > > It's the same, right? Make sense.
Right.
In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes, so, I think, in general we want to see more pr_foo() and less printk().
-ss
| |