lkml.org 
[lkml]   [2018]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()
On (06/21/18 09:59), Dmitry Vyukov wrote:
> >
> >> + printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
> >> + (address < PAGE_SIZE ? "NULL pointer dereference" :
> >> + "paging request"), (void *) address);
> >
> > Perhaps pr_alert() ?
>
> It's the same, right? Make sense.

Right.

In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes,
so, I think, in general we want to see more pr_foo() and less printk().

-ss

\
 
 \ /
  Last update: 2018-06-21 10:17    [W:0.058 / U:2.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site