lkml.org 
[lkml]   [2018]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()
On Wed, Jun 20, 2018 at 3:55 PM, Dmitry Vyukov <dvyukov@gmail.com> wrote:
> From: Dmitry Vyukov <dvyukov@google.com>
>
> KERN_CONT leads to split lines in kernel output
> and complicates useful changes to printk like
> printing context before each line.
>
> Only acceptable use of continuations is basically
> boot-time testing.
>
> Get rid of it.

> + printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
> + (address < PAGE_SIZE ? "NULL pointer dereference" :
> + "paging request"), (void *) address);

Perhaps pr_alert() ?

Btw, parens are redundant for the first argument.

P.S. And personally I would rather do
if (address < PAGE_SIZE)
pr_alert(...NULL pointer dereference...);
else
pr_alert(...paging request...);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-06-21 03:06    [W:0.066 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site