Messages in this thread Patch in this message | | | From | Zhouyang Jia <> | Subject | [PATCH] isdn/i4l: add error handling for try_module_get | Date | Tue, 12 Jun 2018 12:43:53 +0800 |
| |
When try_module_get fails, the lack of error-handling code may cause unexpected results.
This patch adds error-handling code after calling try_module_get.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com> --- drivers/isdn/i4l/isdn_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c index 7c6f3f5..7e52851 100644 --- a/drivers/isdn/i4l/isdn_common.c +++ b/drivers/isdn/i4l/isdn_common.c @@ -71,7 +71,8 @@ static int isdn_add_channels(isdn_driver_t *d, int drvidx, int n, int adding); static inline void isdn_lock_driver(isdn_driver_t *drv) { - try_module_get(drv->interface->owner); + if (!try_module_get(drv->interface->owner)) + printk(KERN_WARNING "isdn_lock_driver: cannot get module\n"); drv->locks++; } -- 2.7.4
| |