lkml.org 
[lkml]   [2018]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 13/16] mtd: rawnand: qcom: minor code reorganization for bad block check
Hi Abhishek,


> @@ -2141,12 +2127,10 @@ static int qcom_nandc_block_bad(struct mtd_info *mtd, loff_t ofs)
> goto err;
> }
>
> - bbpos = mtd->writesize - host->cw_size * (ecc->steps - 1);
> -
> - bad = nandc->data_buffer[bbpos] != 0xff;
> + bad = bbm_bytes_buf[0] != 0xff;

BTW, as there are host->bbm_size bytes that can inform on the block
state, don't we need to check all of them?

>
> if (chip->options & NAND_BUSWIDTH_16)
> - bad = bad || (nandc->data_buffer[bbpos + 1] != 0xff);
> + bad = bad || (bbm_bytes_buf[1] != 0xff);
> err:
> return bad;
> }

Thanks,
Miquèl

\
 
 \ /
  Last update: 2018-05-26 10:59    [W:0.300 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site