lkml.org 
[lkml]   [2018]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional
    Hi Abhishek,

    On Fri, 25 May 2018 17:51:31 +0530, Abhishek Sahu
    <absahu@codeaurora.org> wrote:

    > If nand-ecc-strength specified in DT, then controller will use
    > this ECC strength otherwise ECC strength will be calculated
    > according to chip requirement and available OOB size.
    >
    > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
    > ---
    > * Changes from v2:
    > NONE
    >
    > * Changes from v1:
    > NEW PATCH
    >
    > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > index 73d336be..f246aa0 100644
    > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt
    > @@ -45,11 +45,13 @@ Required properties:
    > number (e.g., 0, 1, 2, etc.)
    > - #address-cells: see partition.txt
    > - #size-cells: see partition.txt
    > -- nand-ecc-strength: see nand.txt
    > - nand-ecc-step-size: must be 512. see nand.txt for more details.

    I think you can squash the two dt-bindings commits as they are tightly
    related to each other.

    >
    > Optional properties:
    > - nand-bus-width: see nand.txt
    > +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will
    > + be used according to chip requirement and available
    > + OOB size.
    >
    > Each nandcs device node may optionally contain a 'partitions' sub-node, which
    > further contains sub-nodes describing the flash partition mapping. See



    --
    Miquel Raynal, Bootlin (formerly Free Electrons)
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2018-05-26 10:45    [W:4.119 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site