Messages in this thread | | | Date | Sat, 19 May 2018 21:42:35 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data |
| |
On Fri 2018-05-18 11:16:55, Jiri Slaby wrote: > ENTRY was intended for functions and shall be paired with ENDPROC. > ENTRY also aligns symbols which creates unnecessary holes here between > data. > > So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64, > as these symbols are local only. > > We could use SYM_DATA_LOCAL for these symbols, but it was discouraged > earlier [1]. > > [1] https://lkml.org/lkml/2017/4/27/244 > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |