Messages in this thread | | | Date | Fri, 18 May 2018 08:20:34 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip v3 4/7] kprobes: Ignore break_handler |
| |
* Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Ignore break_handler related code because it was only > used by jprobe and jprobe is removed.
I changed this description to:
============ Subject: kprobes: Don't call the ->break_handler() in generic kprobes code
Don't call the ->break_handler() from the core kprobes code, because it was only used by jprobes which got removed.
( In a followup patch we'll remove the remaining calls in low level arch handlers as well and remove the callback altogether. ) ============
Please try to be a lot less vague in changelogs when it's possible and relevant!
I.e. saying "Ignore break_handler related code" is annoyingly vague, it doesn't explain things well at all. Saying "Don't call the ->break_handler()" is just as compact, yet it also makes it very clear what's done in the patch...
Thanks,
Ingo
| |