lkml.org 
[lkml]   [2018]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -tip v3 4/7] kprobes: Ignore break_handler
    On Fri, 18 May 2018 08:20:34 +0200
    Ingo Molnar <mingo@kernel.org> wrote:

    >
    > * Masami Hiramatsu <mhiramat@kernel.org> wrote:
    >
    > > Ignore break_handler related code because it was only
    > > used by jprobe and jprobe is removed.
    >
    > I changed this description to:
    >
    > ============
    > Subject: kprobes: Don't call the ->break_handler() in generic kprobes code
    >
    > Don't call the ->break_handler() from the core kprobes code, because it was only
    > used by jprobes which got removed.
    >
    > ( In a followup patch we'll remove the remaining calls in low level
    > arch handlers as well and remove the callback altogether. )
    > ============
    >
    > Please try to be a lot less vague in changelogs when it's possible and relevant!
    >
    > I.e. saying "Ignore break_handler related code" is annoyingly vague, it doesn't
    > explain things well at all. Saying "Don't call the ->break_handler()" is just as
    > compact, yet it also makes it very clear what's done in the patch...

    OK, I'll try to describe more concretely and straightforwardly.

    Thank you for telling me your advice!!

    >
    > Thanks,
    >
    > Ingo


    --
    Masami Hiramatsu <mhiramat@kernel.org>

    \
     
     \ /
      Last update: 2018-05-18 16:14    [W:3.331 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site