Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 11 May 2018 13:15:43 -0700 | Subject | Re: [PATCH v8 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs |
| |
Hi,
On Wed, May 9, 2018 at 10:01 AM, Lina Iyer <ilina@codeaurora.org> wrote: > +int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg) > +{ > + int ret; > + > + if (!msg || !msg->cmds || !msg->num_cmds || > + msg->num_cmds > MAX_RPMH_PAYLOAD) { > + WARN_ON(1); > + return -EINVAL; > + } > + > + do { > + ret = tcs_write(drv, msg); > + if (ret == -EBUSY) { > + pr_info_ratelimited("TCS Busy, retrying RPMH message send: addr=%#x\n", > + msg->cmds[0].addr); > + udelay(10); > + } > + } while (ret == -EBUSY); > + > + return ret; > +} > +EXPORT_SYMBOL(rpmh_rsc_send_data);
Here and elsewhere in this series: why EXPORT_SYMBOL in this case? This is only exported to rpmh.c, right? You don't need EXPORT_SYMBOL for that. The Makefile puts rpmh.c and rpmh-rsc.c together in the same "qcom_rpmh.o", and then even further the KConfig lists this as bool so both are builtin to the kernel.
-Doug
| |