lkml.org 
[lkml]   [2018]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings()
On Tue, Apr 03, 2018 at 10:30:50PM -0300, Jefferson Capovilla wrote:
> Fix 'line over 80 characters' issue found by checkpatch.pl script in
> mtk_set_link_ksettings().
>
> Signed-off-by: Jefferson Capovilla <jefcap@gmail.com>
> ---
> drivers/staging/mt7621-eth/ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
> index 38ba0c0..e9f4092 100644
> --- a/drivers/staging/mt7621-eth/ethtool.c
> +++ b/drivers/staging/mt7621-eth/ethtool.c
> @@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
> mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
> mac->phy_flags = MTK_PHY_FLAG_PORT;
> } else if (mac->hw->mii_bus) {
> - mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
> + mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
> + cmd->base.phy_address);
> if (!mac->phy_dev)
> return -ENODEV;
> mac->phy_flags = MTK_PHY_FLAG_ATTACH;
> @@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
> }
>
> return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
> -

You did this too :(

Don't lie in a changelog text, please fix up and resend.

greg k-h

\
 
 \ /
  Last update: 2018-04-23 15:25    [W:0.034 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site