[lkml]   [2018]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try
On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote:
> Commit 65c79230576 tried to clear the custom firmware path on exit by
> writing a single space to the firmware_class.path parameter. This
> doesn't work because nothing strips this space from the value stored
> and fw_get_filesystem_firmware() only ignores zero-length paths.
> Instead, write a null byte.
> Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> Signed-off-by: Ben Hutchings <>

Acked-by: Luis R. Rodriguez <>

Greg, let me know if you want to take these two in now, or if you want me to
queue them up on my own and then send you what I get in the queue later.


 \ /
  Last update: 2018-04-18 22:39    [W:0.031 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site