Messages in this thread | | | Date | Mon, 23 Apr 2018 12:45:04 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH driver-core 2/2] test_firmware: fix setting old custom fw path back on exit, second try |
| |
On Wed, Apr 18, 2018 at 10:38:09PM +0200, Luis R. Rodriguez wrote: > On Wed, Apr 04, 2018 at 10:38:49PM +0200, Ben Hutchings wrote: > > Commit 65c79230576 tried to clear the custom firmware path on exit by > > writing a single space to the firmware_class.path parameter. This > > doesn't work because nothing strips this space from the value stored > > and fw_get_filesystem_firmware() only ignores zero-length paths. > > > > Instead, write a null byte. > > > > Fixes: 0a8adf58475 ("test: add firmware_class loader test") > > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit") > > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > Acked-by: Luis R. Rodriguez <mcgrof@kernel.org> > > Greg, let me know if you want to take these two in now, or if you want me to > queue them up on my own and then send you what I get in the queue later.
I can take them now, thanks.
greg k-h
| |