Messages in this thread | | | Subject | Re: [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces | From | Lars-Peter Clausen <> | Date | Tue, 17 Apr 2018 12:45:20 +0200 |
| |
On 04/10/2018 09:46 AM, Baolin Wang wrote: [...] > +static int sprd_dma_slave_config(struct dma_chan *chan, > + struct dma_slave_config *config) > +{ > + struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > + struct sprd_dma_config *slave_cfg = > + container_of(config, struct sprd_dma_config, config); > +
Please do not overload standard API with custom semantics. This makes the driver incompatible to the API and negates the whole idea of having a common API. E.g. this will crash when somebody passes a normal dma_slave_config struct to this function.
> + memcpy(&schan->slave_cfg, slave_cfg, sizeof(*slave_cfg)); > + return 0; > +}
| |