Messages in this thread | | | Date | Thu, 12 Apr 2018 12:40:13 +0530 | From | Abhishek Sahu <> | Subject | Re: [PATCH 5/9] mtd: nand: qcom: parse read errors for read oob also |
| |
On 2018-04-10 15:33, Miquel Raynal wrote: > Hi Abhishek, > > On Wed, 4 Apr 2018 18:12:21 +0530, Abhishek Sahu > <absahu@codeaurora.org> wrote: > >> read_page and read_oob both calls the read_page_ecc function. >> The QCOM NAND controller protect the OOB available bytes with >> ECC so read errors should be checked for read_oob also. Now >> this patch moves the error checking code inside read_page_ecc >> so caller does not have to check explicitly for read errors. >> >> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > > Nitpick: the prefix should be "mtd: rawnand: qcom: " now as this driver > has been moved to drivers/mtd/nand/raw/. > > Otherwise: > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks Miquel for your review.
I will update the same in this patch and other patches. and rebase my patches over 4.17-rc1 once its available.
Thanks, Abhishek
| |