Messages in this thread Patch in this message | | | From | rao.shoaib@oracle ... | Subject | [PATCH 1/1] MACRO_ARG_REUSE in checkpatch.pl is confused about * in typeof | Date | Sat, 31 Mar 2018 22:04:05 -0700 |
| |
From: Rao Shoaib <rao.shoaib@oracle.com>
Example:
CHECK: Macro argument reuse 'ptr' - possible side-effects? +#define kfree_rcu(ptr, rcu_name) \ + do { \ + unsigned long __off = offsetof(typeof(*(ptr)), rcu_name); \ + struct rcu_head *__rptr = (void *)ptr + __off; \ + __kfree_rcu(__rptr, __off); \ + } while (0)
Fix supplied by Joe Perches.
Signed-off-by: Rao Shoaib <rao.shoaib@oracle.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d40403..def6bb2 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4998,7 +4998,7 @@ sub process { next if ($arg =~ /\.\.\./); next if ($arg =~ /^type$/i); my $tmp_stmt = $define_stmt; - $tmp_stmt =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g; + $tmp_stmt =~ s/\b(?:typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*(?:\s*\*\s*)*\s*\(*\s*$arg\s*\)*\b//g; $tmp_stmt =~ s/\#+\s*$arg\b//g; $tmp_stmt =~ s/\b$arg\s*\#\#//g; my $use_cnt = $tmp_stmt =~ s/\b$arg\b//g; -- 2.7.4
| |