lkml.org 
[lkml]   [2018]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device
On Sun, Apr 01, 2018 at 11:41:42PM +0300, Tal Gilboa wrote:
> On 3/31/2018 12:05 AM, Bjorn Helgaas wrote:
> > From: Tal Gilboa <talgi@mellanox.com>
> >
> > Add pcie_bandwidth_available() to compute the bandwidth available to a
> > device. This may be limited by the device itself or by a slower upstream
> > link leading to the device.
> >
> > The available bandwidth at each link along the path is computed as:
> >
> > link_speed * link_width * (1 - encoding_overhead)
> >
> > The encoding overhead is about 20% for 2.5 and 5.0 GT/s links using 8b/10b
> > encoding, and about 1.5% for 8 GT/s or higher speed links using 128b/130b
> > encoding.
> >
> > Also return the device with the slowest link and the speed and width of
> > that link.
> >
> > Signed-off-by: Tal Gilboa <talgi@mellanox.com>
> > [bhelgaas: changelog, leave pcie_get_minimum_link() alone for now, return
> > bw directly, use pci_upstream_bridge(), check "next_bw <= bw" to find
> > uppermost limiting device, return speed/width of the limiting device]
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > drivers/pci/pci.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/pci.h | 3 +++
> > 2 files changed, 57 insertions(+)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 9ce89e254197..e00d56b12747 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -5146,6 +5146,60 @@ int pcie_get_minimum_link(struct pci_dev *dev, enum pci_bus_speed *speed,
> > }
> > EXPORT_SYMBOL(pcie_get_minimum_link);
> > +/**
> > + * pcie_bandwidth_available - determine minimum link settings of a PCIe
> > + * device and its bandwidth limitation
> > + * @dev: PCI device to query
> > + * @limiting_dev: storage for device causing the bandwidth limitation
> > + * @speed: storage for speed of limiting device
> > + * @width: storage for width of limiting device
> > + *
> > + * Walk up the PCI device chain and find the point where the minimum
> > + * bandwidth is available. Return the bandwidth available there and (if
> > + * limiting_dev, speed, and width pointers are supplied) information about
> > + * that point.
> > + */
> > +u32 pcie_bandwidth_available(struct pci_dev *dev, struct pci_dev **limiting_dev,
> > + enum pci_bus_speed *speed,
> > + enum pcie_link_width *width)
> > +{
> > + u16 lnksta;
> > + enum pci_bus_speed next_speed;
> > + enum pcie_link_width next_width;
> > + u32 bw, next_bw;
> > +
> > + *speed = PCI_SPEED_UNKNOWN;
> > + *width = PCIE_LNK_WIDTH_UNKNOWN;
>
> This is not safe anymore, now that we allow speed/width=NULL.

Good catch, thanks!

\
 
 \ /
  Last update: 2018-04-02 02:41    [W:0.126 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site