lkml.org 
[lkml]   [2018]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net 0/4] net: dsa: Use strncpy() for ethtool::get_strings
From
Date
Hi David,

On 03/01/2018 04:25 PM, Florian Fainelli wrote:
> Hi all,
>
> After turning on KASAN on one of my systems, I started getting lots of out of
> bounds errors while fetching a given port's statistics, and indeed using
> memcpy() is unsafe for copying strings, so let's use strncpy() instead.

Looks like only patch 1 is necessary, but there are more drivers with
the same pattern under drivers/net/phy: marvell.c, micrel.c and
bcm-phy-lib.c, so I will submit a v2 with those fixed.

>
> Florian Fainelli (4):
> net: dsa: b53: Use strncpy() for ethtool::get_strings
> net: dsa: loop: Use strncpy() for ethtool::get_strings
> net: dsa: microchip: Utilize strncpy() for ethtool::get_strings
> net: dsa: mv88e6xxx: Utilize strncpy() for ethtool::get_strings
>
> drivers/net/dsa/b53/b53_common.c | 4 ++--
> drivers/net/dsa/dsa_loop.c | 4 ++--
> drivers/net/dsa/microchip/ksz_common.c | 4 ++--
> drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>

--
Florian

\
 
 \ /
  Last update: 2018-03-02 05:35    [W:0.156 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site