Messages in this thread | | | Subject | Re: [PATCH net 4/4] net: dsa: mv88e6xxx: Utilize strncpy() for ethtool::get_strings | From | Florian Fainelli <> | Date | Thu, 1 Mar 2018 20:21:34 -0800 |
| |
On 03/01/2018 07:08 PM, Andrew Lunn wrote: > On Thu, Mar 01, 2018 at 04:25:29PM -0800, Florian Fainelli wrote: >> Do not use memcpy() which is not safe, but instead use strncpy() which >> will make sure that the string is NUL terminated (in the Linux >> implementation) if the string is smaller than the length specified. This >> fixes KASAN out of bounds warnings while fetching port statistics. >> >> Fixes: f5e2ed022dff ("dsa: mv88e6xxx: Add Second back of statistics") > > I'm sure it goes back much further than that.
You are right, it appears that I used the most recent commit that changed the stats last.
This is not actually needed per-se here because the string is defined to be ETH_GSTRING_LEN bytes, so unlike b53, we are not copying past the buffer, in fact only the first patch is really necessary.
Thanks!
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > Andrew >
-- Florian
| |