Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Fri, 23 Feb 2018 09:09:33 +1100 | Subject | [PATCH 1/3] staging: lustre: lov: use correct env in lov_io_data_version_end() |
| |
lov - the logical object volume manager - is responsible for striping data across multiple volumes.
So when it is given a request, it creates one or more sub-requests, one for each target volume. Each sub_io request has a sub_env environment which it operates in.
When lov_io_data_version_end() calls lov_io_end_wrapper() to wait for and close off a sub_io, it passes the wrong environment.
This causes an LINVRNT() to fail in cl2osc_io(), and may cause other problems.
This patch changes the call to use ->sub_env, much like other code in the same file.
Fixes: f0cf21abcccc ("staging: lustre: clio: add CIT_DATA_VERSION and remove IOC_LOV_GETINFO") Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/staging/lustre/lustre/lov/lov_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_io.c b/drivers/staging/lustre/lustre/lov/lov_io.c index c0dbf6cd53b4..b823f8a21856 100644 --- a/drivers/staging/lustre/lustre/lov/lov_io.c +++ b/drivers/staging/lustre/lustre/lov/lov_io.c @@ -483,7 +483,7 @@ lov_io_data_version_end(const struct lu_env *env, const struct cl_io_slice *ios) struct lov_io_sub *sub; list_for_each_entry(sub, &lio->lis_active, sub_linkage) { - lov_io_end_wrapper(env, sub->sub_io); + lov_io_end_wrapper(sub->sub_env, sub->sub_io); parent->u.ci_data_version.dv_data_version += sub->sub_io->u.ci_data_version.dv_data_version;
| |