lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add
    If lstcon_test_add sets 'ret' (passed by reference) to 1,
    then lst_test_add_ioctl() ignores the return value.
    This isn't justified - the return value must be zero for 'ret'
    to be meaningful.

    Signed-off-by: NeilBrown <neilb@suse.com>
    ---
    drivers/staging/lustre/lnet/selftest/conctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c
    index 51497cf9a832..a2d8092bdeb7 100644
    --- a/drivers/staging/lustre/lnet/selftest/conctl.c
    +++ b/drivers/staging/lustre/lnet/selftest/conctl.c
    @@ -670,7 +670,7 @@ static int lst_test_add_ioctl(struct lstio_test_args *args)
    args->lstio_tes_param_len,
    &ret, args->lstio_tes_resultp);

    - if (ret)
    + if (!rc && ret)
    rc = (copy_to_user(args->lstio_tes_retp, &ret,
    sizeof(ret))) ? -EFAULT : 0;
    out:

    \
     
     \ /
      Last update: 2018-02-22 23:12    [W:3.600 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site