lkml.org 
[lkml]   [2018]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] net/ibmvnic: Remove tests of member address
    Date
    The driver was checking for non-NULL address.
    - adapter->napi[i]

    This is pointless as these will be always non-NULL, since the
    'dapter->napi' is allocated in init_napi().
    It is safe to get rid of useless checks for addresses to fix the
    coccinelle warning:
    >>drivers/net/ethernet/ibm/ibmvnic.c: test of a variable/field address
    Since such statements always return true, they are redundant.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    CC: Paul Mackerras <paulus@samba.org>
    CC: Michael Ellerman <mpe@ellerman.id.au>
    CC: Thomas Falcon <tlfalcon@linux.ibm.com>
    CC: John Allen <jallen@linux.ibm.com>
    CC: "David S. Miller" <davem@davemloft.net>
    CC: linuxppc-dev@lists.ozlabs.org
    CC: netdev@vger.kernel.org
    CC: linux-kernel@vger.kernel.org
    ---
    drivers/net/ethernet/ibm/ibmvnic.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
    index ed50b8dee44f..14d00985f087 100644
    --- a/drivers/net/ethernet/ibm/ibmvnic.c
    +++ b/drivers/net/ethernet/ibm/ibmvnic.c
    @@ -773,11 +773,8 @@ static void release_napi(struct ibmvnic_adapter *adapter)
    return;

    for (i = 0; i < adapter->num_active_rx_napi; i++) {
    - if (&adapter->napi[i]) {
    - netdev_dbg(adapter->netdev,
    - "Releasing napi[%d]\n", i);
    - netif_napi_del(&adapter->napi[i]);
    - }
    + netdev_dbg(adapter->netdev, "Releasing napi[%d]\n", i);
    + netif_napi_del(&adapter->napi[i]);
    }

    kfree(adapter->napi);
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-11 05:23    [W:4.262 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site