| From | Michael Ellerman <> | Subject | Re: [PATCH v6 07/18] of: dynamic: change type of of_{at,de}tach_node() to void | Date | Wed, 07 Nov 2018 23:08:28 +1100 |
| |
frowand.list@gmail.com writes:
> From: Frank Rowand <frank.rowand@sony.com> > > of_attach_node() and of_detach_node() always return zero, so > their return value is meaningless.
But should they always return zero?
At least __of_attach_node_sysfs() can fail in several ways.
And there's also this in __of_detach_node() which should probably be returning an error:
if (WARN_ON(of_node_check_flag(np, OF_DETACHED))) return;
Seems to me we should instead be fixing these to propagate errors, rather than hiding them?
cheers
|