lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 07/18] of: dynamic: change type of of_{at,de}tach_node() to void
Date
frowand.list@gmail.com writes:

> From: Frank Rowand <frank.rowand@sony.com>
>
> of_attach_node() and of_detach_node() always return zero, so
> their return value is meaningless.

But should they always return zero?

At least __of_attach_node_sysfs() can fail in several ways.

And there's also this in __of_detach_node() which should probably be
returning an error:

if (WARN_ON(of_node_check_flag(np, OF_DETACHED)))
return;


Seems to me we should instead be fixing these to propagate errors,
rather than hiding them?

cheers

\
 
 \ /
  Last update: 2018-11-07 13:09    [W:1.775 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site