lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 06/18] of: overlay: do not duplicate properties from overlay for new nodes
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    When allocating a new node, add_changeset_node() was duplicating the
    properties from the respective node in the overlay instead of
    allocating a node with no properties.

    When this patch is applied the errors reported by the devictree
    unittest from patch "of: overlay: add tests to validate kfrees from
    overlay removal" will no longer occur. These error messages are of
    the form:

    "OF: ERROR: ..."

    and the unittest results will change from:

    ### dt-test ### end of unittest - 203 passed, 7 failed

    to

    ### dt-test ### end of unittest - 210 passed, 0 failed

    Tested-by: Alan Tull <atull@kernel.org>
    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    ---
    drivers/of/overlay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
    index 6fd8e6145e10..9808aae4621a 100644
    --- a/drivers/of/overlay.c
    +++ b/drivers/of/overlay.c
    @@ -393,7 +393,7 @@ static int add_changeset_node(struct overlay_changeset *ovcs,
    break;

    if (!tchild) {
    - tchild = __of_node_dup(node, node_kbasename);
    + tchild = __of_node_dup(NULL, node_kbasename);
    if (!tchild)
    return -ENOMEM;

    --
    Frank Rowand <frank.rowand@sony.com>
    \
     
     \ /
      Last update: 2018-11-05 16:29    [W:4.161 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site