Messages in this thread Patch in this message | | | From | Olof Johansson <> | Subject | [PATCH] kdb: fix strncpy warning | Date | Fri, 2 Nov 2018 14:24:05 -0700 |
| |
kdb does a strncpy(a, b, strlen(b)+1), which makes no sense. Might as well do a strcpy at this point.
Fixes this warning:
In function 'strncpy', inlined from 'kallsyms_symbol_next' at kernel/debug/kdb/kdb_support.c:239:4: ./include/linux/string.h:253:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
Signed-off-by: Olof Johansson <olof@lixom.net> --- kernel/debug/kdb/kdb_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c index 990b3cc526c8..d5af8b38b84d 100644 --- a/kernel/debug/kdb/kdb_support.c +++ b/kernel/debug/kdb/kdb_support.c @@ -236,7 +236,7 @@ int kallsyms_symbol_next(char *prefix_name, int flag) while ((name = kdb_walk_kallsyms(&pos))) { if (strncmp(name, prefix_name, prefix_len) == 0) { - strncpy(prefix_name, name, strlen(name)+1); + strcpy(prefix_name, name); return 1; } } -- 2.11.0
| |